Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4c7f259 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

USB: kaweth.c: use GFP_ATOMIC under spin_lock 



The problem is that we call this with a spin lock held.  The call tree
is:
	kaweth_start_xmit() holds kaweth->device_lock.
	-> kaweth_async_set_rx_mode()
	   -> kaweth_control()
	      -> kaweth_internal_control_msg()

The kaweth_internal_control_msg() function is only called from
kaweth_control() which used GFP_ATOMIC for its allocations.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 42493570

drivers/net/usb/kaweth.c

+1 −1
Original line number Diff line number Diff line
@@ -1314,7 +1314,7 @@ static int kaweth_internal_control_msg(struct usb_device *usb_dev, 
        int retv;

        int length = 0; /* shut up GCC */



        urb = usb_alloc_urb(0, GFP_NOIO);

	urb = usb_alloc_urb(0, GFP_ATOMIC);

        if (!urb)

                return -ENOMEM;