Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dccb3b0e authored by Thomas Meyer's avatar Thomas Meyer Committed by Tony Lindgren
Browse files

arm: mach-omap2: mux: use kstrdup() 

Use kstrdup rather than duplicating its implementation

The semantic patch that makes this output is available
in scripts/coccinelle/api/kstrdup.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/



Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent ae65eb72

arch/arm/mach-omap2/mux.c

+4 −10
Original line number Diff line number Diff line
@@ -821,11 +821,10 @@ static void __init omap_mux_set_cmdline_signals(void) 
	if (!omap_mux_options)

		return;



	options = kmalloc(strlen(omap_mux_options) + 1, GFP_KERNEL);

	options = kstrdup(omap_mux_options, GFP_KERNEL);

	if (!options)

		return;



	strcpy(options, omap_mux_options);

	next_opt = options;



	while ((token = strsep(&next_opt, ",")) != NULL) {
@@ -855,24 +854,19 @@ static int __init omap_mux_copy_names(struct omap_mux *src, 


	for (i = 0; i < OMAP_MUX_NR_MODES; i++) {

		if (src->muxnames[i]) {

			dst->muxnames[i] =

				kmalloc(strlen(src->muxnames[i]) + 1,

			dst->muxnames[i] = kstrdup(src->muxnames[i],

						   GFP_KERNEL);

			if (!dst->muxnames[i])

				goto free;

			strcpy(dst->muxnames[i], src->muxnames[i]);

		}

	}



#ifdef CONFIG_DEBUG_FS

	for (i = 0; i < OMAP_MUX_NR_SIDES; i++) {

		if (src->balls[i]) {

			dst->balls[i] =

				kmalloc(strlen(src->balls[i]) + 1,

					GFP_KERNEL);

			dst->balls[i] = kstrdup(src->balls[i], GFP_KERNEL);

			if (!dst->balls[i])

				goto free;

			strcpy(dst->balls[i], src->balls[i]);

		}

	}

#endif