Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9ed6947 authored by Roland Dreier's avatar Roland Dreier Committed by Nicholas Bellinger
Browse files

target: Clean up logic in transport_put_cmd() 



No need to have a goto where a return is clearer.

Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@risingtidesystems.com>
parent 06e97b48

drivers/target/target_core_transport.c

+4 −5
Original line number Diff line number Diff line
@@ -1966,9 +1966,10 @@ static void transport_put_cmd(struct se_cmd *cmd) 
	unsigned long flags;



	spin_lock_irqsave(&cmd->t_state_lock, flags);

	if (atomic_read(&cmd->t_fe_count)) {

		if (!atomic_dec_and_test(&cmd->t_fe_count))

			goto out_busy;

	if (atomic_read(&cmd->t_fe_count) &&

	    !atomic_dec_and_test(&cmd->t_fe_count)) {

		spin_unlock_irqrestore(&cmd->t_state_lock, flags);

		return;

	}



	if (cmd->transport_state & CMD_T_DEV_ACTIVE) {
@@ -1980,8 +1981,6 @@ static void transport_put_cmd(struct se_cmd *cmd) 
	transport_free_pages(cmd);

	transport_release_cmd(cmd);

	return;

out_busy:

	spin_unlock_irqrestore(&cmd->t_state_lock, flags);

}



void *transport_kmap_data_sg(struct se_cmd *cmd)