Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7515b88 authored by Jarod Wilson's avatar Jarod Wilson Committed by Mauro Carvalho Chehab
Browse files

[media] Revert "V4L/DVB: cx23885: Enable Message Signaled Interrupts(MSI)" 



This reverts commit e38030f3.

MSI flat-out doesn't work right on cx2388x devices yet. There are now
multiple reports of cards that hard-lock systems when MSI is enabled,
including my own HVR-1250 when trying to use its built-in IR receiver.
Disable MSI and it works just fine. Similar for another user's HVR-1270.
Issues have also been reported with the HVR-1850 when MSI is enabled,
and the 1850 behavior sounds similar to an as-yet-undiagnosed issue I've
seen with an 1800.

CC: stable@kernel.org
CC: Steven Toth <stoth@kernellabs.com>
CC: Kusanagi Kouichi <slash@ac.auone-net.jp>
Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
Acked-by: default avatarAndy Walls <awalls@md.metrocast.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ddc6ff31

drivers/media/video/cx23885/cx23885-core.c

+2 −7
Original line number Diff line number Diff line
@@ -2060,10 +2060,6 @@ static int __devinit cx23885_initdev(struct pci_dev *pci_dev, 
		goto fail_irq;

	}



	if (!pci_enable_msi(pci_dev))

		err = request_irq(pci_dev->irq, cx23885_irq,

				  IRQF_DISABLED, dev->name, dev);

	else

	err = request_irq(pci_dev->irq, cx23885_irq,

			  IRQF_SHARED | IRQF_DISABLED, dev->name, dev);

	if (err < 0) {
@@ -2114,7 +2110,6 @@ static void __devexit cx23885_finidev(struct pci_dev *pci_dev) 


	/* unregister stuff */

	free_irq(pci_dev->irq, dev);

	pci_disable_msi(pci_dev);



	cx23885_dev_unregister(dev);

	v4l2_device_unregister(v4l2_dev);