Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5ca9db8 authored by Thomas Meyer's avatar Thomas Meyer Committed by Greg Kroah-Hartman
Browse files

USB: wusb: Use kcalloc instead of kzalloc to allocate array 

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 87763842

drivers/usb/wusbcore/security.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -354,7 +354,7 @@ int wusb_dev_4way_handshake(struct wusbhc *wusbhc, struct wusb_dev *wusb_dev, 
	struct wusb_keydvt_in keydvt_in;

	struct wusb_keydvt_in keydvt_in;

	struct wusb_keydvt_out keydvt_out;

	struct wusb_keydvt_out keydvt_out;





	hs = kzalloc(3*sizeof(hs[0]), GFP_KERNEL);

	hs = kcalloc(3, sizeof(hs[0]), GFP_KERNEL);

	if (hs == NULL) {

	if (hs == NULL) {

		dev_err(dev, "can't allocate handshake data\n");

		dev_err(dev, "can't allocate handshake data\n");

		goto error_kzalloc;

		goto error_kzalloc;