Commit d5123480 authored Oct 11, 2011 by Gao feng Committed by David S. Miller Oct 18, 2011

netconsole: enable netconsole can make net_device refcnt incorrent



There is no check if netconsole is enabled current.
so when exec echo 1 > enabled;
the reference of net_device will increment always.

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Flavio Leitner <fbl@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6230c9b4

drivers/net/netconsole.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -307,6 +307,11 @@ static ssize_t store_enabled(struct netconsole_target *nt,
		return err;
		if (enabled < 0 \|\| enabled > 1)
		return -EINVAL;
		if (enabled == nt->enabled) {
		printk(KERN_INFO "netconsole: network logging has already %s\n",
		nt->enabled ? "started" : "stopped");
		return -EINVAL;
		}

		if (enabled) { /* 1 */