Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d420d9e3 authored by Roland Dreier's avatar Roland Dreier
Browse files

IB/mlx4: Factor out setting WQE data segment entries 



Factor code to set data segment entries out of mlx4_ib_post_send()
into set_data_seg().  This cleans up the code and lets the compiler do
a better job -- on x86_64:

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-16 (-16)
function                                     old     new   delta
mlx4_ib_post_send                           1598    1582     -16

Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 80885456

drivers/infiniband/hw/mlx4/qp.c

+9 −6
Original line number Diff line number Diff line
@@ -1183,6 +1183,14 @@ static int mlx4_wq_overflow(struct mlx4_ib_wq *wq, int nreq, struct ib_cq *ib_cq 
	return cur + nreq >= wq->max_post;

}



static void set_data_seg(struct mlx4_wqe_data_seg *dseg,

			 struct ib_sge *sg)

{

	dseg->byte_count = cpu_to_be32(sg->length);

	dseg->lkey       = cpu_to_be32(sg->lkey);

	dseg->addr       = cpu_to_be64(sg->addr);

}



int mlx4_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,

		      struct ib_send_wr **bad_wr)

{
@@ -1313,12 +1321,7 @@ int mlx4_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, 
		}



		for (i = 0; i < wr->num_sge; ++i) {

			((struct mlx4_wqe_data_seg *) wqe)->byte_count =

				cpu_to_be32(wr->sg_list[i].length);

			((struct mlx4_wqe_data_seg *) wqe)->lkey =

				cpu_to_be32(wr->sg_list[i].lkey);

			((struct mlx4_wqe_data_seg *) wqe)->addr =

				cpu_to_be64(wr->sg_list[i].addr);

			set_data_seg(wqe, wr->sg_list + i);



			wqe  += sizeof (struct mlx4_wqe_data_seg);

			size += sizeof (struct mlx4_wqe_data_seg) / 16;