Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d04ff9c0 authored by Sarah Sharp's avatar Sarah Sharp Committed by Greg Kroah-Hartman
Browse files

xhci: Fix resume issues on Renesas chips in Samsung laptops 



commit 1aa9578c1a9450fb21501c4f549f5b1edb557e6d upstream.

Don Zickus <dzickus@redhat.com> writes:

Some co-workers of mine bought Samsung laptops that had mostly usb3 ports.
Those ports did not resume correctly (the driver would timeout communicating
and fail).  This led to frustration as suspend/resume is a common use for
laptops.

Poking around, I applied the reset on resume quirk to this chipset and the
resume started working.  Reloading the xhci_hcd module had been the temporary
workaround.

Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
Reported-by: default avatarDon Zickus <dzickus@redhat.com>
Tested-by: default avatarPrarit Bhargava <prarit@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c16d2409

drivers/usb/host/xhci-pci.c

+5 −0
Original line number Original line Diff line number Diff line
@@ -113,6 +113,11 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) 
		xhci_dbg(xhci, "QUIRK: Resetting on resume\n");

		xhci_dbg(xhci, "QUIRK: Resetting on resume\n");

		xhci->quirks |= XHCI_TRUST_TX_LENGTH;

		xhci->quirks |= XHCI_TRUST_TX_LENGTH;

	}

	}

	if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&

			pdev->device == 0x0015 &&

			pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG &&

			pdev->subsystem_device == 0xc0cd)

		xhci->quirks |= XHCI_RESET_ON_RESUME;

	if (pdev->vendor == PCI_VENDOR_ID_VIA)

	if (pdev->vendor == PCI_VENDOR_ID_VIA)

		xhci->quirks |= XHCI_RESET_ON_RESUME;

		xhci->quirks |= XHCI_RESET_ON_RESUME;

}

}