Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0229ae3 authored by Andy Grover's avatar Andy Grover Committed by Nicholas Bellinger
Browse files

target: Enforce 1 page max for control cdb buffer sizes 



Due to all cdbs' data buffers being referenced by scatterlists, buffers
of more than a page are not contiguous. Instead of handling this in all
control command handlers, we may be able to get away with just limiting
control cdb data buffers to one page. The only control CDBs we handle that
have potentially large data buffers are REPORT LUNS and UNMAP, so if we
didn't want to live with this limitation, they would need to be modified
to walk the pages in the data buffer's sgl.

Signed-off-by: default avatarAndy Grover <agrover@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 05d1c7c0

drivers/target/target_core_transport.c

+5 −0
Original line number Diff line number Diff line
@@ -3562,6 +3562,11 @@ static int transport_generic_cmd_sequencer( 
		cmd->data_length = size;

	}



	/* Let's limit control cdbs to a page, for simplicity's sake. */

	if ((cmd->se_cmd_flags & SCF_SCSI_CONTROL_SG_IO_CDB) &&

	    size > PAGE_SIZE)

		goto out_invalid_cdb_field;



	transport_set_supported_SAM_opcode(cmd);

	return ret;

include/target/target_core_base.h

+1 −0
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 
/* Used by transport_generic_allocate_iovecs() */

#define TRANSPORT_IOV_DATA_BUFFER		5

/* Maximum Number of LUNs per Target Portal Group */

/* Don't raise above 511 or REPORT_LUNS needs to handle >1 page */

#define TRANSPORT_MAX_LUNS_PER_TPG		256

/*

 * By default we use 32-byte CDBs in TCM Core and subsystem plugin code.