Commit cf043172 authored Apr 30, 2012 by Franky Lin Committed by John W. Linville May 02, 2012

brcmfmac: fix a double spin_unlock_irqrestore issue in dpc



dpc_tl_lock is not acquired in the error handle code for bus down.
But it's unlocked using spin_unlock_irqrestore after finishing task
list walk down. Grab the lock before breaking the loop to avoid a
double unlock.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 66f2c99a

drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2637,6 +2637,7 @@ static int brcmf_sdbrcm_dpc_thread(void *data)
		/* after stopping the bus, exit thread */
		brcmf_sdbrcm_bus_stop(bus->sdiodev->dev);
		bus->dpc_tsk = NULL;
		spin_lock_irqsave(&bus->dpc_tl_lock, flags);
		break;
		}