Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca4e771f authored by Michael Krufky's avatar Michael Krufky Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (12303): cx23885: check pointers before dereferencing in dprintk macro 



When enabling debug with v4l_debug set to 2 or greater, the driver
OOPS's on startup.  Checks dev pointer before dereferencing, in
order to prevent this OOPS.

Signed-off-by: default avatarMichael Krufky <mkrufky@kernellabs.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 12a34cc8

drivers/media/video/cx23885/cx23885-417.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -58,7 +58,8 @@ MODULE_PARM_DESC(v4l_debug, "enable V4L debug messages"); 




#define dprintk(level, fmt, arg...)\

#define dprintk(level, fmt, arg...)\

	do { if (v4l_debug >= level) \

	do { if (v4l_debug >= level) \

		printk(KERN_DEBUG "%s: " fmt, dev->name , ## arg);\

		printk(KERN_DEBUG "%s: " fmt, \

		(dev) ? dev->name : "cx23885[?]", ## arg); \

	} while (0)

	} while (0)





static struct cx23885_tvnorm cx23885_tvnorms[] = {

static struct cx23885_tvnorm cx23885_tvnorms[] = {