Commit c491b2ff authored Jul 25, 2008 by Roel Kluin Committed by Linus Torvalds Jul 26, 2008

asic3: platform_get_irq() may return signed unnoticed



asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Cc: Joe Perches <joe@perches.com>
Acked-by: Samuel Ortiz <sameo@openedhand.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f3c6ba98

drivers/mfd/asic3.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -314,10 +314,12 @@ static int __init asic3_irq_probe(struct platform_device *pdev)
		unsigned long clksel = 0;
		unsigned int irq, irq_base;
		int map_size;
		int ret;

		asic->irq_nr = platform_get_irq(pdev, 0);
		if (asic->irq_nr < 0)
		return asic->irq_nr;
		ret = platform_get_irq(pdev, 0);
		if (ret < 0)
		return ret;
		asic->irq_nr = ret;

		/* turn on clock to IRQ controller */
		clksel \|= CLOCK_SEL_CX;