Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3771a35 authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Do not initialise buffer in efx_alloc_special_buffer() 



Currently we initialise the newly allocated buffer to all-1s, which is
important for event queues but not for descriptor queues.  And since
we also do that in efx_nic_init_eventq(), it is completely pointless
to do it here.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
parent ef492f11

drivers/net/ethernet/sfc/nic.c

+0 −3
Original line number Original line Diff line number Diff line
@@ -255,9 +255,6 @@ static int efx_alloc_special_buffer(struct efx_nic *efx, 
	buffer->entries = len / EFX_BUF_SIZE;

	buffer->entries = len / EFX_BUF_SIZE;

	BUG_ON(buffer->dma_addr & (EFX_BUF_SIZE - 1));

	BUG_ON(buffer->dma_addr & (EFX_BUF_SIZE - 1));





	/* All zeros is a potentially valid event so memset to 0xff */

	memset(buffer->addr, 0xff, len);



	/* Select new buffer ID */

	/* Select new buffer ID */

	buffer->index = efx->next_buffer_table;

	buffer->index = efx->next_buffer_table;

	efx->next_buffer_table += buffer->entries;

	efx->next_buffer_table += buffer->entries;