Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf5d95c8 authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

i2c-viapro: Don't log nacks 



Transactions not acked can happen every now and then, in particular
during device detection, and various transaction types can be used for
this purpose. So stop logging this event, except when debugging is
enabled. This is what other similar drivers (e.g. i2c-i801 or
i2c-piix4) do.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent db79f2a1

drivers/i2c/busses/i2c-viapro.c

+1 −7
Original line number Diff line number Diff line
@@ -185,14 +185,8 @@ static int vt596_transaction(u8 size) 
	}



	if (temp & 0x04) {

		int read = inb_p(SMBHSTADD) & 0x01;

		result = -ENXIO;

		/* The quick and receive byte commands are used to probe

		   for chips, so errors are expected, and we don't want

		   to frighten the user. */

		if (!((size == VT596_QUICK && !read) ||

		      (size == VT596_BYTE && read)))

			dev_err(&vt596_adapter.dev, "Transaction error!\n");

		dev_dbg(&vt596_adapter.dev, "No response\n");

	}



	/* Resetting status register */