Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be98da6a authored by Matt Carlson's avatar Matt Carlson Committed by David S. Miller
Browse files

tg3: Fix some checkpatch errors 



This patch fixes the following checkpatch errors:

ERROR: do not use assignment in if condition
+	if ((mss = skb_shinfo(skb)->gso_size) != 0) {

ERROR: do not use assignment in if condition
+	if ((mss = skb_shinfo(skb)->gso_size) != 0) {

ERROR: space prohibited after that '!' (ctx:BxW)
+			if (! netif_carrier_ok(tp->dev) &&
 			    ^

ERROR: space required after that ',' (ctx:VxV)
+#define GET_REG32_LOOP(base,len)		\
                            ^

ERROR: "(foo*)" should be "(foo *)"
+		memcpy(data, ((char*)&val) + b_offset, b_count);

ERROR: do not use assignment in if condition
+		if ((err = tg3_do_mem_test(tp, mem_tbl[i].offset,

Signed-off-by: default avatarMatt Carlson <mcarlson@broadcom.com>
Reviewed-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 702e52cc

drivers/net/tg3.c

+9 −8
Original line number Diff line number Diff line
@@ -5574,8 +5574,8 @@ static netdev_tx_t tg3_start_xmit(struct sk_buff *skb, 


	entry = tnapi->tx_prod;

	base_flags = 0;

	mss = 0;

	if ((mss = skb_shinfo(skb)->gso_size) != 0) {

	mss = skb_shinfo(skb)->gso_size;

	if (mss) {

		int tcp_opt_len, ip_tcp_len;

		u32 hdrlen;
@@ -5781,7 +5781,8 @@ static netdev_tx_t tg3_start_xmit_dma_bug(struct sk_buff *skb, 
	if (skb->ip_summed == CHECKSUM_PARTIAL)

		base_flags |= TXD_FLAG_TCPUDP_CSUM;



	if ((mss = skb_shinfo(skb)->gso_size) != 0) {

	mss = skb_shinfo(skb)->gso_size;

	if (mss) {

		struct iphdr *iph;

		u32 tcp_opt_len, hdr_len;
@@ -10585,8 +10586,8 @@ static int tg3_test_memory(struct tg3 *tp) 
		mem_tbl = mem_tbl_570x;



	for (i = 0; mem_tbl[i].offset != 0xffffffff; i++) {

		if ((err = tg3_do_mem_test(tp, mem_tbl[i].offset,

		    mem_tbl[i].len)) != 0)

		err = tg3_do_mem_test(tp, mem_tbl[i].offset, mem_tbl[i].len);

		if (err)

			break;

	}