Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc83455b authored by Andrey Panin's avatar Andrey Panin Committed by Linus Torvalds
Browse files

[PATCH] fix DMI onboard device discovery 



Attached patch fixes invalid pointer arithmetic in DMI code to make onboard
device discovery working again.

akpm: bug has been present since dmi_find_device() was added in 2.6.14.
Affects ipmi only (I think) - the symptoms weren't described.

akpm: changed to use pointer arithmetic rather than open-coded sizeof.

Signed-off-by: default avatarAndrey Panin <pazke@donpac.ru>
Cc: Corey Minyard <minyard@acm.org>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent b2fd16b4

arch/i386/kernel/dmi_scan.c

+1 −1
Original line number Diff line number Diff line
@@ -106,7 +106,7 @@ static void __init dmi_save_devices(struct dmi_header *dm) 
	struct dmi_device *dev;



	for (i = 0; i < count; i++) {

		char *d = ((char *) dm) + (i * 2);

		char *d = (char *)(dm + 1) + (i * 2);



		/* Skip disabled device */

		if ((*d & 0x80) == 0)