Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb644913 authored by Dan Carpenter's avatar Dan Carpenter Committed by Wim Van Sebroeck
Browse files

watchdog: sch56xx-common: set correct bits in register() 



WDOG_NO_WAY_OUT (3) and WDOG_ACTIVE (0) are the bit numbers, not a mask.
So "data->wddev.status |= WDOG_ACTIVE;" was intended to set bit zero but
it is a no-op.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 664a0d78

drivers/hwmon/sch56xx-common.c

+2 −2
Original line number Diff line number Diff line
@@ -464,9 +464,9 @@ struct sch56xx_watchdog_data *sch56xx_watchdog_register(struct device *parent, 
	data->wddev.min_timeout = 1;

	data->wddev.max_timeout = 255 * 60;

	if (nowayout)

		data->wddev.status |= WDOG_NO_WAY_OUT;

		set_bit(WDOG_NO_WAY_OUT, &data->wddev.status);

	if (output_enable & SCH56XX_WDOG_OUTPUT_ENABLE)

		data->wddev.status |= WDOG_ACTIVE;

		set_bit(WDOG_ACTIVE, &data->wddev.status);



	/* Since the watchdog uses a downcounter there is no register to read

	   the BIOS set timeout from (if any was set at all) ->