Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5ced7cd authored by Jaswinder Singh Rajput's avatar Jaswinder Singh Rajput Committed by Ingo Molnar
Browse files

x86: rename all fields of mpc_lintsrc mpc_X to X 



Impact: cleanup, solve 80 columns wrap problems

It would be cleaner to rename all the mpc->mpc_X fields to
mpc->X - that alone would give 4 characters per usage site.
(we already know that it's an 'mpc' entity -
no need to duplicate that in the field too)

Signed-off-by: default avatarJaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 5df82c7d

arch/x86/include/asm/mpspec_def.h

+7 −7
Original line number Original line Diff line number Diff line
@@ -140,13 +140,13 @@ enum mp_irq_source_types { 
#define MP_APIC_ALL	0xFF

#define MP_APIC_ALL	0xFF





struct mpc_lintsrc {

struct mpc_lintsrc {

	unsigned char mpc_type;

	unsigned char type;

	unsigned char mpc_irqtype;

	unsigned char irqtype;

	unsigned short mpc_irqflag;

	unsigned short irqflag;

	unsigned char mpc_srcbusid;

	unsigned char srcbusid;

	unsigned char mpc_srcbusirq;

	unsigned char srcbusirq;

	unsigned char mpc_destapic;

	unsigned char destapic;

	unsigned char mpc_destapiclint;

	unsigned char destapiclint;

};

};





#define MPC_OEM_SIGNATURE "_OEM"

#define MPC_OEM_SIGNATURE "_OEM"

arch/x86/kernel/mpparse.c

+9 −10
Original line number Original line Diff line number Diff line
@@ -237,9 +237,8 @@ static void __init MP_lintsrc_info(struct mpc_lintsrc *m) 
{

{

	apic_printk(APIC_VERBOSE, "Lint: type %d, pol %d, trig %d, bus %02x,"

	apic_printk(APIC_VERBOSE, "Lint: type %d, pol %d, trig %d, bus %02x,"

		" IRQ %02x, APIC ID %x, APIC LINT %02x\n",

		" IRQ %02x, APIC ID %x, APIC LINT %02x\n",

		m->mpc_irqtype, m->mpc_irqflag & 3,

		m->irqtype, m->irqflag & 3, (m->irqflag >> 2) & 3, m->srcbusid,

		(m->mpc_irqflag >> 2) & 3, m->mpc_srcbusid,

		m->srcbusirq, m->destapic, m->destapiclint);

		m->mpc_srcbusirq, m->mpc_destapic, m->mpc_destapiclint);

}

}





/*

/*
@@ -560,14 +559,14 @@ static inline void __init construct_default_ISA_mptable(int mpc_default_type) 




	construct_ioapic_table(mpc_default_type);

	construct_ioapic_table(mpc_default_type);





	lintsrc.mpc_type = MP_LINTSRC;

	lintsrc.type = MP_LINTSRC;

	lintsrc.mpc_irqflag = 0;	/* conforming */

	lintsrc.irqflag = 0;		/* conforming */

	lintsrc.mpc_srcbusid = 0;

	lintsrc.srcbusid = 0;

	lintsrc.mpc_srcbusirq = 0;

	lintsrc.srcbusirq = 0;

	lintsrc.mpc_destapic = MP_APIC_ALL;

	lintsrc.destapic = MP_APIC_ALL;

	for (i = 0; i < 2; i++) {

	for (i = 0; i < 2; i++) {

		lintsrc.mpc_irqtype = linttypes[i];

		lintsrc.irqtype = linttypes[i];

		lintsrc.mpc_destapiclint = i;

		lintsrc.destapiclint = i;

		MP_lintsrc_info(&lintsrc);

		MP_lintsrc_info(&lintsrc);

	}

	}

}

}