Commit b25ae679 authored Jul 01, 2009 by Jaswinder Singh Rajput Committed by Ingo Molnar Jul 01, 2009

x86: Mark device_nb as static and fix NULL noise



This sparse warning:

  arch/x86/kernel/amd_iommu.c:1195:23: warning: symbol 'device_nb' was not declared. Should it be static?

triggers because device_nb is global but is only used in a
single .c file. change device_nb to static to fix that - this
also addresses the sparse warning.

This sparse warning:

  arch/x86/kernel/amd_iommu.c:1766:10: warning: Using plain integer as NULL pointer

triggers because plain integer 0 is used in place of a NULL
pointer. change 0 to NULL to fix that - this also address the
sparse warning.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>
LKML-Reference: <1246458194.6940.20.camel@hpdv5.satnam>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 44973998

arch/x86/kernel/amd_iommu.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1192,7 +1192,7 @@ out:
	return 0;		return 0;
	}		}

	struct notifier_block device_nb = {		static struct notifier_block device_nb = {
	.notifier_call = device_change_notifier,		.notifier_call = device_change_notifier,
	};		};

	@@ -1763,7 +1763,7 @@ static void alloc_coherent(struct device dev, size_t size,
	flag \|= __GFP_ZERO;		flag \|= __GFP_ZERO;
	virt_addr = (void *)__get_free_pages(flag, get_order(size));		virt_addr = (void *)__get_free_pages(flag, get_order(size));
	if (!virt_addr)		if (!virt_addr)
	return 0;		return NULL;

	paddr = virt_to_phys(virt_addr);		paddr = virt_to_phys(virt_addr);