Commit a52eb6c0 authored Sep 23, 2012 by Frank Schäfer Committed by Mauro Carvalho Chehab Oct 06, 2012

[media] ov2640: select sensor register bank before applying h/v-flip settings

We currently don't select the register bank in ov2640_s_ctrl, so we can end up
writing to DSP register 0x04 instead of sensor register 0x04.
This happens for example when calling ov2640_s_ctrl after ov2640_s_fmt.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent ab99cb18

drivers/media/i2c/soc_camera/ov2640.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -684,6 +684,11 @@ static int ov2640_s_ctrl(struct v4l2_ctrl *ctrl)
		&container_of(ctrl->handler, struct ov2640_priv, hdl)->subdev;
		struct i2c_client *client = v4l2_get_subdevdata(sd);
		u8 val;
		int ret;

		ret = i2c_smbus_write_byte_data(client, BANK_SEL, BANK_SEL_SENS);
		if (ret < 0)
		return ret;

		switch (ctrl->id) {
		case V4L2_CID_VFLIP: