Commit a4696f4b authored Apr 13, 2013 by Dan Carpenter Committed by Deva Ramasubramanian Feb 18, 2014

[media] media: info leak in __media_device_enum_links()

These structs have holes and reserved struct members which aren't
cleared. I've added a memset() so we don't leak stack information.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Change-Id: Ia22c66d36c0a7bcaee60e65a7db406a40f973006
Git-commit: c88e739b1fad662240e99ecbd0bdaac871717987
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Signed-off-by: Deva Ramasubramanian <dramasub@codeaurora.org>

parent 6ed379b1

drivers/media/media-device.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -142,6 +142,8 @@ static long __media_device_enum_links(struct media_device *mdev,

		for (p = 0; p < entity->num_pads; p++) {
		struct media_pad_desc pad;

		memset(&pad, 0, sizeof(pad));
		media_device_kpad_to_upad(&entity->pads[p], &pad);
		if (copy_to_user(&links->pads[p], &pad, sizeof(pad)))
		return -EFAULT;
		@@ -159,6 +161,7 @@ static long __media_device_enum_links(struct media_device *mdev,
		if (entity->links[l].source->entity != entity)
		continue;

		memset(&link, 0, sizeof(link));
		media_device_kpad_to_upad(entity->links[l].source,
		&link.source);
		media_device_kpad_to_upad(entity->links[l].sink,