Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a46043e0 authored by Mark Fasheh's avatar Mark Fasheh Committed by Mark Fasheh
Browse files

ocfs2: log valid inode # on bad inode 



If the inode block isn't valid then we don't want to print the value from
that, instead print the block number which was passed in (which should
always be correct). Also, turn this into a debug print for now - folks who
hit an actual problem always have other logs indicating what the source is.

Signed-off-by: default avatarMark Fasheh <mark.fasheh@oracle.com>
parent ef9f86ce

fs/ocfs2/inode.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -455,8 +455,8 @@ static int ocfs2_read_locked_inode(struct inode *inode, 
	status = -EINVAL;

	status = -EINVAL;

	fe = (struct ocfs2_dinode *) bh->b_data;

	fe = (struct ocfs2_dinode *) bh->b_data;

	if (!OCFS2_IS_VALID_DINODE(fe)) {

	if (!OCFS2_IS_VALID_DINODE(fe)) {

		mlog(ML_ERROR, "Invalid dinode #%llu: signature = %.*s\n",

		mlog(0, "Invalid dinode #%llu: signature = %.*s\n",

		     (unsigned long long)le64_to_cpu(fe->i_blkno), 7,

		     (unsigned long long)args->fi_blkno, 7,

		     fe->i_signature);

		     fe->i_signature);

		goto bail;

		goto bail;

	}

	}