Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a20852d2 authored by Heiko Carstens's avatar Heiko Carstens Committed by Martin Schwidefsky
Browse files

[S390] cmm: fix crash on case conversion 



When the cmm module is compiled into the kernel it will crash when
writing to the R/O data section.
Reason is the lower to upper case conversion of the "sender" module
parameter which ignored the fact that the pointer is preinitialized.

Introduced with 41b42876 "cmm, smsgiucv_app: convert sender to
uppercase"

Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent bf2106ae

arch/s390/mm/cmm.c

+6 −1
Original line number Diff line number Diff line
@@ -23,7 +23,10 @@ 
#include <asm/pgalloc.h>

#include <asm/diag.h>



static char *sender = "VMRMSVM";

#ifdef CONFIG_CMM_IUCV

static char *cmm_default_sender = "VMRMSVM";

#endif

static char *sender;

module_param(sender, charp, 0400);

MODULE_PARM_DESC(sender,

		 "Guest name that may send SMSG messages (default VMRMSVM)");
@@ -440,6 +443,8 @@ static int __init cmm_init(void) 
		int len = strlen(sender);

		while (len--)

			sender[len] = toupper(sender[len]);

	} else {

		sender = cmm_default_sender;

	}



	rc = smsg_register_callback(SMSG_PREFIX, cmm_smsg_target);