Commit a117c551 authored Jan 21, 2015 by Laxminath Kasam Committed by Gerrit - the friendly Code Review server Jan 21, 2015

ASoC: msm: update dev free call after io_unmap



Platform dev data is freed before iounmap for
iomem registers is done. This can result in
freeing of non-existent memory. Fix it by
calling free of platform dev data after iounmap
calls to iomem registers.

Change-Id: I7c399c46918472ebb4867daeb4735c625fe01f7d
Signed-off-by: Laxminath Kasam <lkasam@codeaurora.org>

parent 3fc4ced6

sound/soc/msm/msm8x16.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2722,13 +2722,13 @@ static int msm8x16_asoc_machine_probe(struct platform_device *pdev)
		}
		return 0;
		err:
		devm_kfree(&pdev->dev, pdata);
		if (pdata->vaddr_gpio_mux_spkr_ctl)
		iounmap(pdata->vaddr_gpio_mux_spkr_ctl);
		if (pdata->vaddr_gpio_mux_mic_ctl)
		iounmap(pdata->vaddr_gpio_mux_mic_ctl);
		if (pdata->vaddr_gpio_mux_pcm_ctl)
		iounmap(pdata->vaddr_gpio_mux_pcm_ctl);
		devm_kfree(&pdev->dev, pdata);
		return ret;
		}