Commit 9db48926 authored Jul 17, 2007 by Jeff Garzik

drivers/infiniband/hw/mthca/mthca_qp: kill uninit'd var warning



drivers/infiniband/hw/mthca/mthca_qp.c: In function
  ‘mthca_tavor_post_send’:
drivers/infiniband/hw/mthca/mthca_qp.c:1594: warning: ‘f0’ may be used
  uninitialized in this function
drivers/infiniband/hw/mthca/mthca_qp.c: In function
  ‘mthca_arbel_post_send’:
drivers/infiniband/hw/mthca/mthca_qp.c:1949: warning: ‘f0’ may be used
  uninitialized in this function

Initializing 'f0' is not strictly necessary in either case, AFAICS.

I was considering use of uninitialized_var(), but looking at the
complex flow of control in each function, I feel it is wiser and
safer to simply zero the var and be certain of ourselves.

Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent e5fb4f42

drivers/infiniband/hw/mthca/mthca_qp.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1591,7 +1591,7 @@ int mthca_tavor_post_send(struct ib_qp ibqp, struct ib_send_wr wr,
	int i;		int i;
	int size;		int size;
	int size0 = 0;		int size0 = 0;
	u32 f0;		u32 f0 = 0;
	int ind;		int ind;
	u8 op0 = 0;		u8 op0 = 0;

	@@ -1946,7 +1946,7 @@ int mthca_arbel_post_send(struct ib_qp ibqp, struct ib_send_wr wr,
	int i;		int i;
	int size;		int size;
	int size0 = 0;		int size0 = 0;
	u32 f0;		u32 f0 = 0;
	int ind;		int ind;
	u8 op0 = 0;		u8 op0 = 0;