Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b9cfe7c authored by Kristoffer Glembo's avatar Kristoffer Glembo Committed by David S. Miller
Browse files

greth: greth_set_mac_add would corrupt the MAC address. 



The MAC address was set using the signed char sockaddr->sa_addr
field and thus the address could be corrupted through sign extension.

Signed-off-by: default avatarKristoffer Glembo <kristoffer@gaisler.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c349a528

drivers/net/greth.c

+3 −4
Original line number Original line Diff line number Diff line
@@ -1015,11 +1015,10 @@ static int greth_set_mac_add(struct net_device *dev, void *p) 
		return -EINVAL;

		return -EINVAL;





	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);

	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);

	GRETH_REGSAVE(regs->esa_msb, dev->dev_addr[0] << 8 | dev->dev_addr[1]);

	GRETH_REGSAVE(regs->esa_lsb, dev->dev_addr[2] << 24 | dev->dev_addr[3] << 16 |

		      dev->dev_addr[4] << 8 | dev->dev_addr[5]);





	GRETH_REGSAVE(regs->esa_msb, addr->sa_data[0] << 8 | addr->sa_data[1]);

	GRETH_REGSAVE(regs->esa_lsb,

		      addr->sa_data[2] << 24 | addr->

		      sa_data[3] << 16 | addr->sa_data[4] << 8 | addr->sa_data[5]);

	return 0;

	return 0;

}

}