Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a4c347a authored by Jeykumar Sankaran's avatar Jeykumar Sankaran Committed by Gerrit - the friendly Code Review server
Browse files

msm: mdss: Fix error value on pipe priority mismatch



MDP has a HW limitation that when source split is enabled
and two pipes are staged on the same zorder of a mixer,
the left pipes must of be higher priority than the right.
If MDP couldn't find a right pipe of lower priority, instead
of returning EINVAL, it should return NULL indicating its
failure to allocate a pipe.

Change-Id: Ife9dff64bb17f56b22f9a4015f621c70d7e6c735
Signed-off-by: default avatarJeykumar Sankaran <jsanka@codeaurora.org>
parent c9cb2ef0
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -856,9 +856,9 @@ static struct mdss_mdp_pipe *mdss_mdp_pipe_init(struct mdss_mdp_mixer *mixer,
		struct mdss_mdp_pipe *pool_head = pipe_pool + off;
		off += left_blend_pipe->priority - pool_head->priority + 1;
		if (off >= npipes) {
			pr_err("priority limitation. l_pipe:%d. no low priority %d pipe type available.\n",
			pr_warn("priority limitation. l_pipe:%d. no low priority %d pipe type available.\n",
				left_blend_pipe->num, type);
			return ERR_PTR(-EINVAL);
			return NULL;
		}
	}