Commit 9a215e40 authored Dec 02, 2011 by Johannes Berg Committed by Wey-Yi Guy Dec 08, 2011

iwlagn: fix TID use bug



The driver everywhere uses max TID count as 9,
which is wrong, it should be 8.

I think the reason it uses 9 here is off-by-one
confusion by whoever wrote this. We do use the
value IWL_MAX_TID_COUNT for "not QoS/no TID"
but that is completely correct even if it is 8
and not 9 since 0-7 are only valid.

As a side effect, this fixes the following bug:

 Open BA session requested for 00:23:cd:16:8a:7e tid 8
 ------------[ cut here ]------------
 kernel BUG at drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h:350!
 ...

when you do
echo "tx start 8" > /sys/kernel/debug/ieee80211/*/*/*/*/agg_status

Cc: stable@vger.kernel.org
Reported-by: Nikolay Martynov <mar.kolya@gmail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>

parent 45c30dba

drivers/net/wireless/iwlwifi/iwl-commands.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -814,7 +814,7 @@ struct iwl_qosparam_cmd {
		#define IWLAGN_STATION_COUNT 16

		#define IWL_INVALID_STATION 255
		#define IWL_MAX_TID_COUNT 9
		#define IWL_MAX_TID_COUNT 8

		#define STA_FLG_TX_RATE_MSK cpu_to_le32(1 << 2)
		#define STA_FLG_PWR_SAVE_MSK cpu_to_le32(1 << 8)