Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97d84836 authored by Patrick Caulfield's avatar Patrick Caulfield Committed by Steven Whitehouse
Browse files

[DLM] Telnet to port 21064 can stop all lockspaces 



This patch fixes Red Hat bz#245892

Opening a tcp connection from a cluster member to another cluster member
targeting the dlm port it is enough to stop every dlm operation in the cluster.
This means that GFS and rgmanager will hang.

Signed-Off-By: default avatarPatrick Caulfield <pcaulfie@redhat.com>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent 1875f2f3

fs/dlm/lowcomms.c

+10 −4
Original line number Diff line number Diff line
@@ -720,12 +720,18 @@ static int tcp_accept_from_sock(struct connection *con) 
			INIT_WORK(&othercon->rwork, process_recv_sockets);

			set_bit(CF_IS_OTHERCON, &othercon->flags);

			newcon->othercon = othercon;

		}

			othercon->sock = newsock;

			newsock->sk->sk_user_data = othercon;

			add_sock(newsock, othercon);

			addcon = othercon;

		}

		else {

			printk("Extra connection from node %d attempted\n", nodeid);

			result = -EAGAIN;

			up_write(&newcon->sock_sem);

			goto accept_err;

		}

	}

	else {

		newsock->sk->sk_user_data = newcon;

		newcon->rx_action = receive_from_sock;