Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 971163cb authored by Oliver Wang's avatar Oliver Wang
Browse files

input: sensors: fix the irq not free issue when apds9930 probe fails 



The irq is not freed when the apds9930 sensor chip is not successfully
probed. The freed memory access in the interrupt handler cause a
crash. Thus fix this issue by calling free_irq when probe fails.

Change-Id: Ia584199d35ec09c04fb5632183443ecf1c747f74
Signed-off-by: default avatarOliver Wang <mengmeng@codeaurora.org>
parent 39e3e1e9

drivers/misc/apds993x.c

+9 −9
Original line number Diff line number Diff line
@@ -2292,15 +2292,6 @@ static int apds993x_probe(struct i2c_client *client, 


	mutex_init(&data->update_lock);



	err = request_irq(data->irq, apds993x_interrupt, IRQF_TRIGGER_FALLING,

			   	APDS993X_DRV_NAME, (void *)client);

	if (err < 0) {

		pr_err("%s: Could not allocate APDS993X_INT !\n", __func__);

		goto exit_kfree;

	}



	irq_set_irq_wake(client->irq, 1);



	INIT_DELAYED_WORK(&data->dwork, apds993x_work_handler);



#ifdef ALS_POLLING_ENABLED
@@ -2314,6 +2305,15 @@ static int apds993x_probe(struct i2c_client *client, 
		goto exit_kfree;

	}



	err = request_irq(data->irq, apds993x_interrupt, IRQF_TRIGGER_FALLING,

				APDS993X_DRV_NAME, (void *)client);

	if (err < 0) {

		pr_err("%s: Could not allocate APDS993X_INT !\n", __func__);

		goto exit_kfree;

	}



	irq_set_irq_wake(client->irq, 1);



	/* Register to Input Device */

	data->input_dev_als = input_allocate_device();

	if (!data->input_dev_als) {