Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 923fd703 authored by Michael Buesch's avatar Michael Buesch Committed by John W. Linville
Browse files

b43: Add debugfs firmware debugging knob 



This adds a firmware debugging knob to debugfs.
With this knob it's possible to enable advanced runtime firmware
checks.
For now it only implements one sanity check for the mac-suspend.
In future there'll probably be more.
If CONFIG_B43_DEBUG is disabled, these checks will collapse to nothing.

Signed-off-by: default avatarMichael Buesch <mb@bu3sch.de>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 9b839a74

drivers/net/wireless/b43/debugfs.c

+1 −0
Original line number Diff line number Diff line
@@ -801,6 +801,7 @@ static void b43_add_dynamic_debug(struct b43_wldev *dev) 
	add_dyn_dbg("debug_pwork_fast", B43_DBG_PWORK_FAST, 0);

	add_dyn_dbg("debug_pwork_stop", B43_DBG_PWORK_STOP, 0);

	add_dyn_dbg("debug_lo", B43_DBG_LO, 0);

	add_dyn_dbg("debug_firmware", B43_DBG_FIRMWARE, 0);



#undef add_dyn_dbg

}

drivers/net/wireless/b43/debugfs.h

+1 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ enum b43_dyndbg { /* Dynamic debugging features */ 
	B43_DBG_PWORK_FAST,

	B43_DBG_PWORK_STOP,

	B43_DBG_LO,

	B43_DBG_FIRMWARE,

	__B43_NR_DYNDBG,

};

drivers/net/wireless/b43/main.c

+13 −0
Original line number Diff line number Diff line
@@ -2487,6 +2487,19 @@ static void b43_gpio_cleanup(struct b43_wldev *dev) 
/* http://bcm-specs.sipsolutions.net/EnableMac */

void b43_mac_enable(struct b43_wldev *dev)

{

	if (b43_debug(dev, B43_DBG_FIRMWARE)) {

		u16 fwstate;



		fwstate = b43_shm_read16(dev, B43_SHM_SHARED,

					 B43_SHM_SH_UCODESTAT);

		if ((fwstate != B43_SHM_SH_UCODESTAT_SUSP) &&

		    (fwstate != B43_SHM_SH_UCODESTAT_SLEEP)) {

			b43err(dev->wl, "b43_mac_enable(): The firmware "

			       "should be suspended, but current state is %u\n",

			       fwstate);

		}

	}



	dev->mac_suspended--;

	B43_WARN_ON(dev->mac_suspended < 0);

	if (dev->mac_suspended == 0) {