Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91e8db80 authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

[NETFILTER]: nf_conntrack_h323: turn some printks into DEBUGPs 



Don't spam the ringbuffer with decoding errors. The only printks remaining
are for dropped packets when we're certain they are H.323.

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d3c3f424

net/netfilter/nf_conntrack_h323_main.c

+10 −15
Original line number Diff line number Diff line
@@ -163,9 +163,7 @@ static int get_tpkt_data(struct sk_buff **pskb, unsigned int protoff, 
				}



				/* Fragmented TPKT */

				if (net_ratelimit())

					printk("nf_ct_h323: "

					       "fragmented TPKT\n");

				DEBUGP("nf_ct_h323: fragmented TPKT\n");

				goto clear_out;

			}
@@ -596,8 +594,7 @@ static int h245_help(struct sk_buff **pskb, unsigned int protoff, 
		ret = DecodeMultimediaSystemControlMessage(data, datalen,

							   &mscm);

		if (ret < 0) {

			if (net_ratelimit())

				printk("nf_ct_h245: decoding error: %s\n",

			DEBUGP("nf_ct_h245: decoding error: %s\n",

			       ret == H323_ERROR_BOUND ?

			       "out of bound" : "out of range");

			/* We don't drop when decoding error */
@@ -1137,8 +1134,7 @@ static int q931_help(struct sk_buff **pskb, unsigned int protoff, 
		/* Decode Q.931 signal */

		ret = DecodeQ931(data, datalen, &q931);

		if (ret < 0) {

			if (net_ratelimit())

				printk("nf_ct_q931: decoding error: %s\n",

			DEBUGP("nf_ct_q931: decoding error: %s\n",

			       ret == H323_ERROR_BOUND ?

			       "out of bound" : "out of range");

			/* We don't drop when decoding error */
@@ -1711,8 +1707,7 @@ static int ras_help(struct sk_buff **pskb, unsigned int protoff, 
	/* Decode RAS message */

	ret = DecodeRasMessage(data, datalen, &ras);

	if (ret < 0) {

		if (net_ratelimit())

			printk("nf_ct_ras: decoding error: %s\n",

		DEBUGP("nf_ct_ras: decoding error: %s\n",

		       ret == H323_ERROR_BOUND ?

		       "out of bound" : "out of range");

		goto accept;