Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fab451e authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Christoph Hellwig
Browse files

xfs: kill vn_atime_* helpers. 



Two out of three are unused already, and the third is better done open-coded
with a comment describing what's going on here.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDave Chinner <david@fromorbit.com>
parent 076e6acb

fs/xfs/linux-2.6/xfs_vnode.h

+0 −19
Original line number Diff line number Diff line
@@ -57,25 +57,6 @@ static inline int VN_BAD(struct inode *vp) 
	return is_bad_inode(vp);

}



/*

 * Extracting atime values in various formats

 */

static inline void vn_atime_to_bstime(struct inode *vp, xfs_bstime_t *bs_atime)

{

	bs_atime->tv_sec = vp->i_atime.tv_sec;

	bs_atime->tv_nsec = vp->i_atime.tv_nsec;

}



static inline void vn_atime_to_timespec(struct inode *vp, struct timespec *ts)

{

	*ts = vp->i_atime;

}



static inline void vn_atime_to_time_t(struct inode *vp, time_t *tt)

{

	*tt = vp->i_atime.tv_sec;

}



/*

 * Some useful predicates.

 */

fs/xfs/xfs_itable.c

+6 −1
Original line number Diff line number Diff line
@@ -83,7 +83,12 @@ xfs_bulkstat_one_iget( 
	buf->bs_uid = dic->di_uid;

	buf->bs_gid = dic->di_gid;

	buf->bs_size = dic->di_size;

	vn_atime_to_bstime(VFS_I(ip), &buf->bs_atime);

	/*

	 * We are reading the atime from the Linux inode because the

	 * dinode might not be uptodate.

	 */

	buf->bs_atime.tv_sec = VFS_I(ip)->i_atime.tv_sec;

	buf->bs_atime.tv_nsec = VFS_I(ip)->i_atime.tv_nsec;

	buf->bs_mtime.tv_sec = dic->di_mtime.t_sec;

	buf->bs_mtime.tv_nsec = dic->di_mtime.t_nsec;

	buf->bs_ctime.tv_sec = dic->di_ctime.t_sec;