Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80c67852 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix NULL-derefence with a single mic in STAC auto-mic detection

When only one mic is available and it's an analog mic, the current
IDT/STAC parser may give an Oops.

Reference: bko#25692
	https://bugzilla.kernel.org/show_bug.cgi?id=25692



Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Cc: <stable@kernel.org>
parent 700b65ce
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -3594,7 +3594,7 @@ static int stac_check_auto_mic(struct hda_codec *codec)
		if (check_mic_pin(codec, spec->dmic_nids[i],
		    &fixed, &ext, &dock))
			return 0;
	if (!fixed && !ext && !dock)
	if (!fixed || (!ext && !dock))
		return 0; /* no input to switch */
	if (!(get_wcaps(codec, ext) & AC_WCAP_UNSOL_CAP))
		return 0; /* no unsol support */