Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79404849 authored by Emese Revfy's avatar Emese Revfy Committed by Linus Torvalds
Browse files

checkpatch.pl: extend list of expected-to-be-const structures 



Based on Arjan's suggestion, extend the list of ops structures that should
be const.

Signed-off-by: default avatarEmese Revfy <re.emese@gmail.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Cc: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 22fd2d3e

scripts/checkpatch.pl

+39 −2
Original line number Diff line number Diff line
@@ -2654,9 +2654,46 @@ sub process { 
		if ($line =~ /^.\s*__initcall\s*\(/) {

			WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);

		}

# check for struct file_operations, ensure they are const.

# check for various ops structs, ensure they are const.

		my $struct_ops = qr{acpi_dock_ops|

				address_space_operations|

				backlight_ops|

				block_device_operations|

				dentry_operations|

				dev_pm_ops|

				dma_map_ops|

				extent_io_ops|

				file_lock_operations|

				file_operations|

				hv_ops|

				ide_dma_ops|

				intel_dvo_dev_ops|

				item_operations|

				iwl_ops|

				kgdb_arch|

				kgdb_io|

				kset_uevent_ops|

				lock_manager_operations|

				microcode_ops|

				mtrr_ops|

				neigh_ops|

				nlmsvc_binding|

				pci_raw_ops|

				pipe_buf_operations|

				platform_hibernation_ops|

				platform_suspend_ops|

				proto_ops|

				rpc_pipe_ops|

				seq_operations|

				snd_ac97_build_ops|

				soc_pcmcia_socket_ops|

				stacktrace_ops|

				sysfs_ops|

				tty_operations|

				usb_mon_operations|

				wd_ops}x;

		if ($line !~ /\bconst\b/ &&

		    $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {

		    $line =~ /\bstruct\s+($struct_ops)\b/) {

			WARN("struct $1 should normally be const\n" .

				$herecurr);

		}