Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78220388 authored by Roland Dreier's avatar Roland Dreier
Browse files

IB/ipath: Fix PCI config write size used to clear linkctrl error bits



In slave_or_pri_blk(), pci_write_config_byte() is used to write a
16-bit quantity to clear linkctrl CRC error bits.  This is clearly a
bug and also causes the warning

    drivers/infiniband/hw/ipath/ipath_iba6110.c: In function 'slave_or_pri_blk':
    drivers/infiniband/hw/ipath/ipath_iba6110.c:849: warning: overflow in implicit constant conversion

Fix this by using pci_write_config_word() instead.

Acked-by: default avatarRalph Campbell <ralph.campbell@qlogic.com>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 10a8c3cd
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -845,7 +845,7 @@ static void slave_or_pri_blk(struct ipath_devdata *dd, struct pci_dev *pdev,
			/*
			 * now write them back to clear the error.
			 */
			pci_write_config_byte(pdev, link_off,
			pci_write_config_word(pdev, link_off,
					      linkctrl & (0xf << 8));
		}
	}