Commit 75dab471 authored Oct 28, 2013 by Takashi Iwai Committed by Greg Kroah-Hartman Nov 29, 2013

ALSA: 6fire: Fix probe of multiple cards



commit 9b389a8a022110b4bc055a19b888283544d9eba6 upstream.

The probe code of snd-usb-6fire driver overrides the devices[] pointer
wrongly without checking whether it's already occupied or not.  This
would screw up the device disconnection later.

Spotted by coverity CID 141423.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d389d610

sound/usb/6fire/chip.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -101,7 +101,7 @@ static int usb6fire_chip_probe(struct usb_interface *intf,
		usb_set_intfdata(intf, chips[i]);
		mutex_unlock(&register_mutex);
		return 0;
		} else if (regidx < 0)
		} else if (!devices[i] && regidx < 0)
		regidx = i;
		}
		if (regidx < 0) {