ALSA: asihpi - Fix potential Oops in snd_asihpi_cmode_info()



Dan Carpenter reported that setting 0 to uinfo->value.enumerated.items
in snd_asihpi_cmode_info() may lead to Oops.  This function should
return an error immediately in such a case instead.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 9badda0a

sound/pci/asihpi/asihpi.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -2259,6 +2259,9 @@ static int snd_asihpi_cmode_info(struct snd_kcontrol *kcontrol,
	valid_modes++;		valid_modes++;
	}		}

			if (!valid_modes)
			return -EINVAL;

	uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;		uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
	uinfo->count = 1;		uinfo->count = 1;
	uinfo->value.enumerated.items = valid_modes;		uinfo->value.enumerated.items = valid_modes;