Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74c2d7b0 authored by Gilad Broner's avatar Gilad Broner Committed by Subhash Jadavani
Browse files

scsi: ufs: commit descriptors before setting the doorbell 



Add a write memory barrier to make sure descriptors prepared are actually
written to memory before ringing the doorbell. We have also added the
write memory barrier after ringing the doorbell register so that
controller sees the new request immediately.

Change-Id: Ifb3fb294eda81a5bccddb05227eade1b7453921a
Signed-off-by: default avatarGilad Broner <gbroner@codeaurora.org>
Signed-off-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
parent 19c9d762

drivers/scsi/ufs/ufshcd.c

+6 −0
Original line number Diff line number Diff line
@@ -1148,6 +1148,8 @@ void ufshcd_send_command(struct ufs_hba *hba, unsigned int task_tag) 
	ufshcd_clk_scaling_start_busy(hba);

	__set_bit(task_tag, &hba->outstanding_reqs);

	ufshcd_writel(hba, 1 << task_tag, REG_UTP_TRANSFER_REQ_DOOR_BELL);

	/* Make sure that doorbell is commited immediately */

	wmb();

	ufshcd_cond_add_cmd_trace(hba, task_tag, "send");

	UFSHCD_UPDATE_TAG_STATS(hba, task_tag);

}
@@ -1701,6 +1703,8 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 
		goto out;

	}



	/* Make sure descriptors are ready before ringing the doorbell */

	wmb();

	/* issue command to the controller */

	spin_lock_irqsave(hba->host->host_lock, flags);

	ufshcd_send_command(hba, tag);
@@ -1902,6 +1906,8 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba, 


	hba->dev_cmd.complete = &wait;



	/* Make sure descriptors are ready before ringing the doorbell */

	wmb();

	spin_lock_irqsave(hba->host->host_lock, flags);

	ufshcd_send_command(hba, tag);

	spin_unlock_irqrestore(hba->host->host_lock, flags);