Commit 6b960610 authored Apr 20, 2012 by yan Committed by Greg Kroah-Hartman Apr 23, 2012

lib/kobject.c : Remove redundant check in create_dir



create_dir is a static function used only in kobject_add_internal.
There's no need to do check here, for kobject_add_internal will
reject kobject with invalid name.

Signed-off-by: Yan Hong <clouds.yan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9169c012

lib/kobject.c

+5 −7

Original line number	Diff line number	Diff line
		@@ -47,14 +47,12 @@ static int populate_dir(struct kobject *kobj)
		static int create_dir(struct kobject *kobj)
		{
		int error = 0;
		if (kobject_name(kobj)) {
		error = sysfs_create_dir(kobj);
		if (!error) {
		error = populate_dir(kobj);
		if (error)
		sysfs_remove_dir(kobj);
		}
		}
		return error;
		}