Commit 6a2bceec authored Jun 02, 2006 by Amy Griffis Committed by Al Viro Jun 20, 2006

[PATCH] fix AUDIT_FILTER_PREPEND handling



Clear AUDIT_FILTER_PREPEND flag after adding rule to list.  This
fixes three problems when a rule is added with the -A syntax:

    - auditctl displays filter list as "(null)"
    - the rule cannot be removed using -d
    - a duplicate rule can be added with -a

Signed-off-by: Amy Griffis <amy.griffis@hp.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 0a73dccc

kernel/auditfilter.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1083,6 +1083,7 @@ static inline int audit_add_rule(struct audit_entry *entry,

	if (entry->rule.flags & AUDIT_FILTER_PREPEND) {		if (entry->rule.flags & AUDIT_FILTER_PREPEND) {
	list_add_rcu(&entry->list, list);		list_add_rcu(&entry->list, list);
			entry->rule.flags &= ~AUDIT_FILTER_PREPEND;
	} else {		} else {
	list_add_tail_rcu(&entry->list, list);		list_add_tail_rcu(&entry->list, list);
	}		}