Commit 6a20bd45 authored Nov 25, 2010 by Jiri Slaby Committed by Greg Kroah-Hartman Nov 29, 2010

NET: wan/x25, fix ldisc->open retval



We should never return positive values from ldisc->open, tty layer
doesn't (and never did) expect that.

If we do that, weird things like warnings in tty_ldisc_close happen.

Not sure if dev->base_addr is used somehow now.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Andrew Hendry <andrew.hendry@gmail.com>
Cc: linux-x25@vger.kernel.org
Tested-by: Sergey Lapin <slapin@ossfans.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 7f90cfc5

drivers/net/wan/x25_asy.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -582,7 +582,7 @@ static int x25_asy_open_tty(struct tty_struct *tty)
	if (err)		if (err)
	return err;		return err;
	/* Done. We have linked the TTY line to a channel. */		/* Done. We have linked the TTY line to a channel. */
	return sl->dev->base_addr;		return 0;
	}		}