Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 646124a8 authored by Satish Kodishala's avatar Satish Kodishala Committed by Gerrit - the friendly Code Review server
Browse files

radio: tavarua: Fixes for memory leaks. 



Freeing memory allocated in case of failures.

Change-Id: I323b9c414d725d6b9dc0698e2ed03ef9c2450e5f
CRs-fixed: 557048
Signed-off-by: default avatarSatish Kodishala <skodisha@codeaurora.org>
parent dce17fb3

drivers/media/radio/radio-tavarua.c

+18 −10
Original line number Diff line number Diff line
@@ -4466,8 +4466,8 @@ static int __init tavarua_probe(struct platform_device *pdev) 


	struct marimba_fm_platform_data *tavarua_pdata;

	struct tavarua_device *radio;

	int retval;

	int i;

	int retval = 0;

	int i = 0, j = 0;

	FMDBG("%s: probe called\n", __func__);

	/* private data allocation */

	radio = kzalloc(sizeof(struct tavarua_device), GFP_KERNEL);
@@ -4480,6 +4480,7 @@ static int __init tavarua_probe(struct platform_device *pdev) 
	tavarua_pdata = pdev->dev.platform_data;

	radio->pdata = tavarua_pdata;

	radio->dev = &pdev->dev;

	radio->wqueue = NULL;

	platform_set_drvdata(pdev, radio);



	/* video device allocation */
@@ -4509,15 +4510,16 @@ static int __init tavarua_probe(struct platform_device *pdev) 
		if (kfifo_alloc_rc!=0) {

			printk(KERN_ERR "%s: failed allocating buffers %d\n",

				__func__, kfifo_alloc_rc);

			goto err_bufs;

			retval = -ENOMEM;

			goto err_all;

		}

	}

	/* initializing the device count  */

	atomic_set(&radio->users, 1);

	radio->xfr_in_progress = 0;

	radio->xfr_bytes_left = 0;

	for (i = 0; i < TAVARUA_XFR_MAX; i++)

		radio->pending_xfrs[i] = 0;

	for (j = 0; j < TAVARUA_XFR_MAX; j++)

		radio->pending_xfrs[j] = 0;



	/* init transmit data */

	radio->tx_mode = TAVARUA_TX_RT;
@@ -4548,11 +4550,16 @@ static int __init tavarua_probe(struct platform_device *pdev) 
    /*Start the worker thread for event handling and register read_int_stat

	as worker function*/

	radio->wqueue  = create_singlethread_workqueue("kfmradio");

	if (!radio->wqueue)

		return -ENOMEM;

	if (!radio->wqueue) {

		retval = -ENOMEM;

		goto err_all;

	}



	/* register video device */

	if (video_register_device(radio->videodev, VFL_TYPE_RADIO, radio_nr)) {

	retval = video_register_device(radio->videodev,

			VFL_TYPE_RADIO,

			radio_nr);

	if (retval != 0) {

		printk(KERN_WARNING DRIVER_NAME

				": Could not register video device\n");

		goto err_all;
@@ -4562,8 +4569,9 @@ static int __init tavarua_probe(struct platform_device *pdev) 


err_all:

	video_device_release(radio->videodev);

err_bufs:

	for (; i > -1; i--)

	if (radio->wqueue)

		destroy_workqueue(radio->wqueue);

	for (i--; i >= 0; i--)

		kfifo_free(&radio->data_buf[i]);

err_radio:

	kfree(radio);