Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 616a6b92 authored by Junjie Wu's avatar Junjie Wu
Browse files

clock-gcc-8994: Change halt check type for UFS and LPASS clocks 



UFS symbol clocks have external sources. Due to HW design, there is no
guarantee that 1) the downstream branch clocks are turned on after
turning on the sources; 2) the downstream branch clocks are turned off
before turning off the sources.

gcc_lpass_q6_axi_clk has a separate hardware signal that might keep it
on even if Apps votes it off.

Therefore, make the halt check for these clocks as delay instead of
polling the status bit to avoid warnings.

Change-Id: Ic5632b8ddb126ac0bd7e6976d92791aa977bb47d
Signed-off-by: default avatarJunjie Wu <junjiew@codeaurora.org>
parent 64adbd29

drivers/clk/qcom/clock-gcc-8994.c

+5 −0
Original line number Diff line number Diff line
@@ -1989,6 +1989,7 @@ static struct branch_clk gcc_lpass_q6_axi_clk = { 
	.cbcr_reg = LPASS_Q6_AXI_CBCR,

	.has_sibling = 1,

	.base = &virt_base,

	.halt_check = DELAY,

	.c = {

		.dbg_name = "gcc_lpass_q6_axi_clk",

		.ops = &clk_ops_branch,
@@ -2351,6 +2352,7 @@ static struct branch_clk gcc_ufs_rx_symbol_0_clk = { 
	.cbcr_reg = UFS_RX_SYMBOL_0_CBCR,

	.has_sibling = 1,

	.base = &virt_base,

	.halt_check = DELAY,

	.c = {

		.dbg_name = "gcc_ufs_rx_symbol_0_clk",

		.ops = &clk_ops_branch,
@@ -2362,6 +2364,7 @@ static struct branch_clk gcc_ufs_rx_symbol_1_clk = { 
	.cbcr_reg = UFS_RX_SYMBOL_1_CBCR,

	.has_sibling = 1,

	.base = &virt_base,

	.halt_check = DELAY,

	.c = {

		.dbg_name = "gcc_ufs_rx_symbol_1_clk",

		.ops = &clk_ops_branch,
@@ -2387,6 +2390,7 @@ static struct branch_clk gcc_ufs_tx_symbol_0_clk = { 
	.cbcr_reg = UFS_TX_SYMBOL_0_CBCR,

	.has_sibling = 1,

	.base = &virt_base,

	.halt_check = DELAY,

	.c = {

		.dbg_name = "gcc_ufs_tx_symbol_0_clk",

		.ops = &clk_ops_branch,
@@ -2398,6 +2402,7 @@ static struct branch_clk gcc_ufs_tx_symbol_1_clk = { 
	.cbcr_reg = UFS_TX_SYMBOL_1_CBCR,

	.has_sibling = 1,

	.base = &virt_base,

	.halt_check = DELAY,

	.c = {

		.dbg_name = "gcc_ufs_tx_symbol_1_clk",

		.ops = &clk_ops_branch,