Commit 60686744 authored Aug 10, 2005 by James Bottomley Committed by Linus Torvalds Aug 10, 2005

[PATCH] remove name length check in a workqueue



We have a chek in there to make sure that the name won't overflow
task_struct.comm[], but it's triggering for scsi with lots of HBAs, only
scsi is using single-threaded workqueues which don't append the "/%d"
anyway.

All too hard.  Just kill the BUG_ON.

Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>

[ kthread_create() uses vsnprintf() and limits the thing, so no
  actual overflow can actually happen regardless ]

Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 3462b925

kernel/workqueue.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -308,8 +308,6 @@ struct workqueue_struct __create_workqueue(const char name,
		struct workqueue_struct *wq;
		struct task_struct *p;

		BUG_ON(strlen(name) > 10);

		wq = kmalloc(sizeof(*wq), GFP_KERNEL);
		if (!wq)
		return NULL;