Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c17c2e7 authored by Subhash Jadavani's avatar Subhash Jadavani
Browse files

scsi: ufs: increase fDeviceInit query response timeout 



fDeviceInit query response time for some devices is too long that default
query request timeout of 100ms may not be enough. Experiments show that
fDeviceInit response sometimes takes 500ms so to be on safer side this
change sets the timeout to 600ms. Without this change, we might
unnecessarily have to retry fDeviceInit query requests multiple times and
each query request timeout prints one error message.

Change-Id: Ib44fef65c9e408201eb6e0ff9e02d0703d4bf5d9
Signed-off-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
parent a983672d

drivers/scsi/ufs/ufshcd.c

+11 −1
Original line number Diff line number Diff line
@@ -124,6 +124,12 @@ 
#define QUERY_REQ_RETRIES 10

/* Query request timeout */

#define QUERY_REQ_TIMEOUT 100 /* msec */

/*

 * Query request timeout for fDeviceInit flag

 * fDeviceInit query response time for some devices is too large that default

 * QUERY_REQ_TIMEOUT may not be enough for such devices.

 */

#define QUERY_FDEVICEINIT_REQ_TIMEOUT 600 /* msec */



/* Task management command timeout */

#define TM_CMD_TIMEOUT	100 /* msecs */
@@ -2538,6 +2544,7 @@ int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode, 
	struct ufs_query_req *request = NULL;

	struct ufs_query_res *response = NULL;

	int err, index = 0, selector = 0;

	int timeout = QUERY_REQ_TIMEOUT;



	BUG_ON(!hba);
@@ -2570,7 +2577,10 @@ int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode, 
		goto out_unlock;

	}



	err = ufshcd_exec_dev_cmd(hba, DEV_CMD_TYPE_QUERY, QUERY_REQ_TIMEOUT);

	if (idn == QUERY_FLAG_IDN_FDEVICEINIT)

		timeout = QUERY_FDEVICEINIT_REQ_TIMEOUT;



	err = ufshcd_exec_dev_cmd(hba, DEV_CMD_TYPE_QUERY, timeout);



	if (err) {

		dev_err(hba->dev,