Commit 545b9fd3 authored Jun 02, 2009 by Nick Piggin Committed by Al Viro Jun 11, 2009

fs: remove incorrect I_NEW warnings



Some filesystems can call in to sync an inode that is still in the
I_NEW state (eg. ext family, when mounted with -osync). This is OK
because the filesystem has sole access to the new inode, so it can
modify i_state without races (because no other thread should be
modifying it, by definition of I_NEW). Ie. a false positive, so
remove the warnings.

The races are described here 7ef0d737,
which is also where the warnings were introduced.

Reported-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 8688b863

fs/fs-writeback.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -289,7 +289,6 @@ __sync_single_inode(struct inode inode, struct writeback_control wbc)
		int ret;

		BUG_ON(inode->i_state & I_SYNC);
		WARN_ON(inode->i_state & I_NEW);

		/* Set I_SYNC, reset I_DIRTY */
		dirty = inode->i_state & I_DIRTY;
		@@ -314,7 +313,6 @@ __sync_single_inode(struct inode inode, struct writeback_control wbc)
		}

		spin_lock(&inode_lock);
		WARN_ON(inode->i_state & I_NEW);
		inode->i_state &= ~I_SYNC;
		if (!(inode->i_state & I_FREEING)) {
		if (!(inode->i_state & I_DIRTY) &&