Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 508fb0bd authored by Rom Lemarchand's avatar Rom Lemarchand Committed by Mitchel Humpherys
Browse files

ion: add new ion_user_handle_t type for the user-space token 



Declare new ion_user_handle_t type to contain the token returned to user-space.
This allows a 2-step migration of the user-space code to a new kernel header
first, then will allow us to change the definition of the ion_user_handle_type_t
to int without breaking the API.

Change-Id: I4200b6600df8e56fe98cf1580a13a65cb25ec646
Signed-off-by: default avatarRom Lemarchand <romlem@google.com>
(cherry picked from commit ebb8269bbb05b06ecedca3e21b3e65f23d48eadd)
Git-commit: 29f271de6ffdf6a96375cd244986617e87afc8d0
Git-repo: https://android.googlesource.com/kernel/common


[mitchelh@codeaurora.org: applied ion.h changes to file different
 location since we already did the uapi split for ion]
Signed-off-by: default avatarMitchel Humpherys <mitchelh@codeaurora.org>
parent 00e7ac1a

drivers/gpu/ion/ion.c

+2 −2
Original line number Diff line number Diff line
@@ -1305,7 +1305,7 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 
		if (IS_ERR(handle))

			return PTR_ERR(handle);



		data.handle = (struct ion_handle *)handle->id;

		data.handle = (ion_user_handle_t)handle->id;



		if (copy_to_user((void __user *)arg, &data, sizeof(data))) {

			ion_free(client, handle);
@@ -1358,7 +1358,7 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 
		if (IS_ERR(handle))

			ret = PTR_ERR(handle);

		else

			data.handle = (struct ion_handle *)handle->id;

			data.handle = (ion_user_handle_t)handle->id;



		if (copy_to_user((void __user *)arg, &data,

				 sizeof(struct ion_fd_data)))

include/uapi/linux/ion.h

+5 −3
Original line number Diff line number Diff line
@@ -21,6 +21,8 @@ 
#include <linux/types.h>



struct ion_handle;

typedef struct ion_handle *ion_user_handle_t;



/**

 * enum ion_heap_types - list of all possible types of heaps

 * @ION_HEAP_TYPE_SYSTEM:	 memory allocated via vmalloc
@@ -90,7 +92,7 @@ struct ion_allocation_data { 
	size_t align;

	unsigned int heap_mask;

	unsigned int flags;

	struct ion_handle *handle;

	ion_user_handle_t handle;

};



/**
@@ -104,7 +106,7 @@ struct ion_allocation_data { 
 * provides the file descriptor and the kernel returns the handle.

 */

struct ion_fd_data {

	struct ion_handle *handle;

	ion_user_handle_t handle;

	int fd;

};
@@ -113,7 +115,7 @@ struct ion_fd_data { 
 * @handle:	a handle

 */

struct ion_handle_data {

	struct ion_handle *handle;

	ion_user_handle_t handle;

};



/**