Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c600ecb authored by Jordan Crouse's avatar Jordan Crouse
Browse files

msm: kgsl: Fix a possible memory leak in kgsl_ioctl_map_user_mem 



If secure memory is requested and not supported we leave the
function without freeing up the entry.

Change-Id: Ic0dedbad25e8827b9438e0ba4eded0e37faa8352
Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
parent e9756715

drivers/gpu/msm/kgsl.c

+2 −2
Original line number Diff line number Diff line
@@ -2995,7 +2995,7 @@ long kgsl_ioctl_map_user_mem(struct kgsl_device_private *dev_priv, 
			(param->flags & KGSL_MEMFLAGS_SECURE)) {

		dev_WARN_ONCE(dev_priv->device->dev, 1,

				"Secure buffer not supported");

		return -EINVAL;

		goto error;

	}



	if (param->flags & KGSL_MEMFLAGS_SECURE) {
@@ -3004,7 +3004,7 @@ long kgsl_ioctl_map_user_mem(struct kgsl_device_private *dev_priv, 
			KGSL_DRV_ERR(dev_priv->device,

				 "Secure buffer size %zx must be %x aligned",

				 entry->memdesc.size, SZ_1M);

			return -EINVAL;

			goto error;

		}

	}