Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4aca81bf authored by Pandiyarajan Pitchaimuthu's avatar Pandiyarajan Pitchaimuthu Committed by Kalle Valo
Browse files

ath6kl: Make use of return value from ath6kl_diag_read() 



In ath6kl_read_fwlogs(), return value from ath6kl_diag_read()is not
used to bail out in case of any errors in reading fw log. No real issue
is observed because of this, reported by source code analyzer.

kvalo: fix a long line warning

Signed-off-by: default avatarPandiyarajan Pitchaimuthu <c_ppitch@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent c95dcb59

drivers/net/wireless/ath/ath6kl/main.c

+8 −3
Original line number Original line Diff line number Diff line
@@ -293,13 +293,17 @@ int ath6kl_read_fwlogs(struct ath6kl *ar) 
	}

	}





	address = TARG_VTOP(ar->target_type, debug_hdr_addr);

	address = TARG_VTOP(ar->target_type, debug_hdr_addr);

	ath6kl_diag_read(ar, address, &debug_hdr, sizeof(debug_hdr));

	ret = ath6kl_diag_read(ar, address, &debug_hdr, sizeof(debug_hdr));

	if (ret)

		goto out;





	address = TARG_VTOP(ar->target_type,

	address = TARG_VTOP(ar->target_type,

			    le32_to_cpu(debug_hdr.dbuf_addr));

			    le32_to_cpu(debug_hdr.dbuf_addr));

	firstbuf = address;

	firstbuf = address;

	dropped = le32_to_cpu(debug_hdr.dropped);

	dropped = le32_to_cpu(debug_hdr.dropped);

	ath6kl_diag_read(ar, address, &debug_buf, sizeof(debug_buf));

	ret = ath6kl_diag_read(ar, address, &debug_buf, sizeof(debug_buf));

	if (ret)

		goto out;





	loop = 100;

	loop = 100;
@@ -322,7 +326,8 @@ int ath6kl_read_fwlogs(struct ath6kl *ar) 




		address = TARG_VTOP(ar->target_type,

		address = TARG_VTOP(ar->target_type,

				    le32_to_cpu(debug_buf.next));

				    le32_to_cpu(debug_buf.next));

		ath6kl_diag_read(ar, address, &debug_buf, sizeof(debug_buf));

		ret = ath6kl_diag_read(ar, address, &debug_buf,

				       sizeof(debug_buf));

		if (ret)

		if (ret)

			goto out;

			goto out;